Sector Nord AG: #571 AgentTicketProcess Mobile-View is not showing all elements of ActivityDialog #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennykorsukewitz
requested changes
Oct 18, 2024
var/httpd/htdocs/skins/Agent/default/css/Core.Agent.TicketProcess.css
Outdated
Show resolved
Hide resolved
| @@ -69,7 +69,7 @@ | |||
| <input type="hidden" name="IsMainWindow" id="IsMainWindow" value="[% Data.IsMainWindow | html %]"/> | |||
| <input type="hidden" name="IsProcessEnroll" id="IsProcessEnroll" value="[% Data.IsProcessEnroll | html %]"/> | |||
| <input type="hidden" name="FormID" value="[% Data.FormID | html %]"/> | |||
| <div class="LayoutPopup ARIARoleMain"> | |||
| <div class="LayoutPopup ARIARoleMain NoMarginTop"> | |||
There was a problem hiding this comment.
Please use the already existing class no-margin. This sets all margins to zero. Since only the top is set, this would be a solid solution.
var/httpd/htdocs/skins/Agent/default/css/Core.FlexboxModel.css
dennykorsukewitz
requested changes
Oct 18, 2024
Kernel/Output/HTML/Templates/Standard/ProcessManagement/ActivityDialogHeader.tt
Outdated
Show resolved
Hide resolved
…ess.css Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
…tyDialogHeader.tt Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
|
Hello @dennykorsukewitz, now with no-margin |
dennykorsukewitz
approved these changes
Oct 18, 2024
dennykorsukewitz
added
3 - wait for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is a way to fix the bug in AgentTicketProcess Mobile-View
Additional information
#571
Checklist